From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Wed, 15 Jan 2014 17:05:45 +0000 (+0100)
Subject: Notification: don't expand the content on a destroyed notification
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2902
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=5413010c6075ec2af766c2cf3e5766ccad3e11fb;p=gnome-shell.git

Notification: don't expand the content on a destroyed notification

If the notification is destroyed between an allocate and the redraw,
the meta_later is invoked on a destroyed object, and fails because
the clutter calls are invalid at that point.

https://bugzilla.gnome.org/show_bug.cgi?id=722547
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 650361115..f3806b7e6 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1001,6 +1001,9 @@ const Notification = new Lang.Class({
             Meta.later_add(Meta.LaterType.BEFORE_REDRAW,
                            Lang.bind(this,
                                      function() {
+                                         if (this._destroyed)
+                                             return false;
+
                                         if (this._canExpandContent()) {
                                             this._addBannerBody();
                                             this._table.add_style_class_name('multi-line-notification');